Implement silent update functionality #2131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you mean by "harder lockouts"?
…On Fri, Aug 18, 2023, 10:58 AM marcustyphoon ***@***.***> wrote:
In theory, this implements a fourth version number field that, when
incremented, causes an extension to be updated without notifying the user
(unless they are in force update mode).
Incrementing this field on an extension should do nothing if the user has
not yet installed this PR. Once the user installs this PR, the increment
should be detected as a silent update.
To be very clear: I have not tested this code at all. I literally have
not, as of writing this message, even installed it. If someone could figure
out how to test it, that would be great.
I would love to have this functionality to be able to put harder lockouts
on all of the currently-does-nothing-on-React scripts without spamming the
user with what looks like updates. But reading through this code base's
internals is actual torture.
------------------------------
You can view, comment on, or merge this pull request online at:
#2131
Commit Summary
- 91473c9
<91473c9>
Implement silent update functionality
File Changes
(2 files <https://github.com/new-xkit/XKit/pull/2131/files>)
- *M* Extensions/xkit_patches.js
<https://github.com/new-xkit/XKit/pull/2131/files#diff-ea5f39eec50155bb36f18e7325511f0ad4c00a9376459f0dda3e8562920db8de>
(3)
- *M* Extensions/xkit_updates.js
<https://github.com/new-xkit/XKit/pull/2131/files#diff-308a9917a63c0656c0048fff7147915e85aecd682ee88b6850c12b8347c470b2>
(22)
Patch Links:
- https://github.com/new-xkit/XKit/pull/2131.patch
- https://github.com/new-xkit/XKit/pull/2131.diff
—
Reply to this email directly, view it on GitHub
<#2131>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZCV4RAMLP7SK3DIBOMMDXV6GJRANCNFSM6AAAAAA3VW4CVU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
In short: run: function() {
if (XKit.page.react) { return; }
/* etc */
}I'm not keen on having to do the Old Sidebar (#2116) thing again, and we have scripts like retags that are intentionally not completely deleted only because they work on legacy (#2088) where that behavior would not be ideal, if we want to continue offering the maximum amount of functionality the codebase can deliver. In general, the ability to push updates guaranteeing that possibly-broken code won't run without appearing the same way a fix would and incorrectly setting user expectations seems valuable to me. That's only worthwhile if the code that enables that doesn't itself break things, though, which I don't know how to test. My track record for bug-free first commits is pretty bad, after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory, this implements a fourth version number field that, when incremented, causes an extension to be updated without notifying the user (unless they are in force update mode).
Incrementing this field on an extension should do nothing if the user has not yet installed this PR. Once the user installs this PR, the increment should be detected as a silent update.
To be very clear: I have not tested this code at all. I literally have not, as of writing this message, even installed it. If someone could figure out how to test it, that would be great.
I would love to have this functionality to be able to put harder lockouts on all of the currently-does-nothing-on-React scripts without spamming the user with what looks like updates. But reading through this code base's internals is actual torture.